Implement Feedback

Assets/CardBaseEntity/ST18/Green/Digimon/Deramon-ST18-09.asset

@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:f13b0d9534349c9d484c2b67dd1bdc35397fc9b353e6eaa5b67e107e5c6cf8a8
-size 1292
+oid sha256:c7cd98810f3e17ca7aa38ee2ae197f5cf33e0cb1de7f7848e8dfb5b1c9131137
+size 1307

Assets/CardBaseEntity/ST18/Green/Digimon/Kiwimon-ST18-06.asset

@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:351d992248783fa30afcc4beeb1db0454d3e2cff4ffc34c8c4a6820a8902a943
-size 1171
+oid sha256:cae2d5f27a3e6cb4f618c48711edca0d83c9a6d790546effd3e7e683aec46a0c
+size 1186

Assets/CardBaseEntity/ST18/Green/Digimon/Zephagamon-ST18-12.asset

@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:73995c2beb08b9563ff66be5a3acb03d77b5b65f9b71651c707085f965028574
-size 1533
+oid sha256:6648628eec3d8c19758532c7c5d71c0e4b5d6ca25e4ea9c9053e7f637ff387f2
+size 1549

Assets/CardEffect/ST18/Green/Deramon_ST18_09.cs

@@ -58,7 +58,7 @@ namespace DCGO.CardEffects.ST18
 
                 bool CanActivateCondition(Hashtable hashtable)
                 {
-                    return CardEffectCommons.IsExistOnBattleAreaDigimon(card) &&
+                    return CardEffectCommons.CanActivateOnDeletion(card) &&
                            CardEffectCommons.HasMatchConditionOwnersHand(card, CanSelectCardCondition);
                 }
 
@@ -104,33 +104,6 @@ namespace DCGO.CardEffects.ST18
 
             #endregion
 
-            #region Rule Text
-
-            if (timing == EffectTiming.None)
-            {
-                ChangeTraitsClass changeTraitsClass = new ChangeTraitsClass();
-                changeTraitsClass.SetUpICardEffect("Trait: Has the [Vegetation] type", CanUseCondition, card);
-                changeTraitsClass.SetUpChangeTraitsClass(changeeTraits: ChangeTraits);
-                cardEffects.Add(changeTraitsClass);
-
-                bool CanUseCondition(Hashtable hashtable)
-                {
-                    return true;
-                }
-
-                List<string> ChangeTraits(CardSource cardSource, List<string> cardTraits)
-                {
-                    if (cardSource == card)
-                    {
-                        cardTraits.Add("Vegetation");
-                    }
-
-                    return cardTraits;
-                }
-            }
-
-            #endregion
-
             return cardEffects;
         }
     }

Assets/CardEffect/ST18/Green/Fluffymon_ST18_01.cs

@@ -16,6 +16,8 @@ namespace DCGO.CardEffects.ST18
                 ActivateClass activateClass = new ActivateClass();
                 activateClass.SetUpICardEffect("Suspend 1 Digimon", CanUseCondition, card);
                 activateClass.SetUpActivateClass(CanActivateCondition, ActivateCoroutine, 1, true, EffectDescription());
+                activateClass.SetIsInheritedEffect(true);
+                activateClass.SetHashString("Suspend_ST18_01");
                 cardEffects.Add(activateClass);
 
                 string EffectDescription()

Assets/CardEffect/ST18/Green/Galemon_ST18_08.cs

@@ -16,7 +16,8 @@ namespace DCGO.CardEffects.ST18
                 ActivateClass activateClass = new ActivateClass();
                 activateClass.SetUpICardEffect("Play a Digimon from your hand or trash.", CanUseCondition, card);
                 activateClass.SetUpActivateClass(CanActivateCondition, ActivateCoroutine, -1, true, EffectDescription());
-                activateClass.SetHashString("PlayDigimon_ST187_08");
+                activateClass.SetIsSecurityEffect(true);
+                activateClass.SetIsDigimonEffect(true);
                 cardEffects.Add(activateClass);
 
                 string EffectDescription()

Assets/CardEffect/ST18/Green/Kiwimon_ST18_06.cs

@@ -17,12 +17,6 @@ namespace DCGO.CardEffects.ST18
                        permanent.CanSuspend;
             }
 
-            bool CanActivateSharedCondition(Hashtable hashtable)
-            {
-                return CardEffectCommons.IsExistOnBattleAreaDigimon(card) &&
-                       CardEffectCommons.HasMatchConditionPermanent(CanSelectPermanentSharedCondition);
-            }
-
             #endregion
 
             #region On Play
@@ -31,7 +25,7 @@ namespace DCGO.CardEffects.ST18
             {
                 ActivateClass activateClass = new ActivateClass();
                 activateClass.SetUpICardEffect("Suspend 1 opponent's Digimon", CanUseCondition, card);
-                activateClass.SetUpActivateClass(CanActivateSharedCondition, ActivateCoroutine, -1, false, EffectDescription());
+                activateClass.SetUpActivateClass(CanActivateCondition, ActivateCoroutine, -1, false, EffectDescription());
                 cardEffects.Add(activateClass);
 
                 string EffectDescription()
@@ -45,6 +39,12 @@ namespace DCGO.CardEffects.ST18
                     return CardEffectCommons.CanTriggerOnPlay(hashtable, card);
                 }
 
+                bool CanActivateCondition(Hashtable hashtable)
+                {
+                    return CardEffectCommons.IsExistOnBattleAreaDigimon(card) &&
+                           CardEffectCommons.HasMatchConditionPermanent(CanSelectPermanentSharedCondition);
+                }
+
                 IEnumerator ActivateCoroutine(Hashtable hashtable)
                 {
                     SelectPermanentEffect selectPermanentEffect = GManager.instance.GetComponent<SelectPermanentEffect>();
@@ -67,14 +67,14 @@ namespace DCGO.CardEffects.ST18
             }
 
             #endregion
-            
+
             #region On Deletion
 
             if (timing == EffectTiming.OnDestroyedAnyone)
             {
                 ActivateClass activateClass = new ActivateClass();
                 activateClass.SetUpICardEffect("Suspend 1 opponent's Digimon", CanUseCondition, card);
-                activateClass.SetUpActivateClass(CanActivateSharedCondition, ActivateCoroutine, -1, false, EffectDescription());
+                activateClass.SetUpActivateClass(CanActivateCondition, ActivateCoroutine, -1, false, EffectDescription());
                 cardEffects.Add(activateClass);
 
                 string EffectDescription()
@@ -88,6 +88,12 @@ namespace DCGO.CardEffects.ST18
                     return CardEffectCommons.CanTriggerOnDeletion(hashtable, card);
                 }
 
+                bool CanActivateCondition(Hashtable hashtable)
+                {
+                    return CardEffectCommons.CanActivateOnDeletion(card) &&
+                           CardEffectCommons.HasMatchConditionPermanent(CanSelectPermanentSharedCondition);
+                }
+
                 IEnumerator ActivateCoroutine(Hashtable hashtable)
                 {
                     SelectPermanentEffect selectPermanentEffect = GManager.instance.GetComponent<SelectPermanentEffect>();
@@ -109,33 +115,6 @@ namespace DCGO.CardEffects.ST18
                 }
             }
 
-            #endregion
-            
-            #region Rule Text
-
-            if (timing == EffectTiming.None)
-            {
-                ChangeTraitsClass changeTraitsClass = new ChangeTraitsClass();
-                changeTraitsClass.SetUpICardEffect("Trait: Has the [Vegetation] type", CanUseCondition, card);
-                changeTraitsClass.SetUpChangeTraitsClass(changeeTraits: ChangeTraits);
-                cardEffects.Add(changeTraitsClass);
-
-                bool CanUseCondition(Hashtable hashtable)
-                {
-                    return true;
-                }
-
-                List<string> ChangeTraits(CardSource cardSource, List<string> cardTraits)
-                {
-                    if (cardSource == card)
-                    {
-                        cardTraits.Add("Vegetation");
-                    }
-
-                    return cardTraits;
-                }
-            }
-
             #endregion
 
             return cardEffects;

Assets/CardEffect/ST18/Green/Muchomon_ST18_05.cs

@@ -16,6 +16,7 @@ namespace DCGO.CardEffects.ST18
                 ActivateClass activateClass = new ActivateClass();
                 activateClass.SetUpICardEffect("1 of your Digimon gains 3000 DP.", CanUseCondition, card);
                 activateClass.SetUpActivateClass(CanActivateCondition, ActivateCoroutine, 1, false, EffectDescription());
+                activateClass.SetHashString("Buff_ST18_05");
                 cardEffects.Add(activateClass);
 
                 string EffectDescription()

Assets/CardEffect/ST18/Green/Parrotmon_ST18_11.cs

@@ -21,7 +21,7 @@ namespace DCGO.CardEffects.ST18
                 string EffectDescription()
                 {
                     return
-                        "[On Play] Suspend 1 of your opponent's Digimon.";
+                        "[On Play] Suspend 1 of your opponent's Digimon. Then, 1 of your opponent's Digimon can't unsuspend until the end of their turn.";
                 }
 
                 bool CanUseCondition(Hashtable hashtable)

Assets/CardEffect/ST18/Green/Pteromon_ST18_04.cs

@@ -27,13 +27,14 @@ namespace DCGO.CardEffects.ST18
 
                 bool CanSelectBirdCardCondition(CardSource cardSource)
                 {
-                    return cardSource.HasBirdTraits;
+                    return cardSource.ContainsTraits("Bird") || 
+                           cardSource.ContainsTraits("Avian");
                 }
 
                 bool CanSelectLiberatorCardCondition(CardSource cardSource)
                 {
                     return cardSource.ContainsTraits("Vortex Warriors") ||
-                           cardSource.ContainsTraits("Liberator") || cardSource.ContainsTraits("LIBERATOR");
+                           cardSource.ContainsTraits("LIBERATOR");
                 }
 
                 bool CanUseCondition(Hashtable hashtable)

Assets/CardEffect/ST18/Green/ShotoKazama_ST18_14.cs

@@ -20,12 +20,11 @@ namespace DCGO.CardEffects.ST18
 
             #region Your Turn
 
-            if (timing == EffectTiming.OnCounterTiming)
+            if (timing == EffectTiming.OnAllyAttack)
             {
                 ActivateClass activateClass = new ActivateClass();
                 activateClass.SetUpICardEffect("Switch attack target of own Digimon", CanUseCondition, card);
                 activateClass.SetUpActivateClass(CanActivateCondition, ActivateCoroutine, -1, true, EffectDescription());
-                activateClass.SetHashString("AttackSwitch_ST18_14");
                 cardEffects.Add(activateClass);
 
                 string EffectDescription()

Assets/CardEffect/ST18/Green/Zephagamon_ST18_12.cs

@@ -95,6 +95,7 @@ namespace DCGO.CardEffects.ST18
                 ActivateClass activateClass = new ActivateClass();
                 activateClass.SetUpICardEffect("Become unaffected by Digimon's effects, gain DP.", CanUseCondition, card);
                 activateClass.SetUpActivateClass(CanActivateCondition, ActivateCoroutine, 1, false, EffectDescription());
+                activateClass.SetHashString("Immunity_ST18_12");
                 cardEffects.Add(activateClass);
 
                 string EffectDescription()
@@ -158,33 +159,6 @@ namespace DCGO.CardEffects.ST18
 
             #endregion
 
-            #region Rule Text
-
-            if (timing == EffectTiming.None)
-            {
-                ChangeTraitsClass changeTraitsClass = new ChangeTraitsClass();
-                changeTraitsClass.SetUpICardEffect("Trait: Has the [Bird Dragon] type", CanUseCondition, card);
-                changeTraitsClass.SetUpChangeTraitsClass(changeeTraits: ChangeTraits);
-                cardEffects.Add(changeTraitsClass);
-
-                bool CanUseCondition(Hashtable hashtable)
-                {
-                    return true;
-                }
-
-                List<string> ChangeTraits(CardSource cardSource, List<string> cardTraits)
-                {
-                    if (cardSource == card)
-                    {
-                        cardTraits.Add("Bird Dragon");
-                    }
-
-                    return cardTraits;
-                }
-            }
-
-            #endregion
-
             return cardEffects;
         }
     }

Assets/CardEffect/ST19/Black/PawnChessmon_ST19_05.cs

@@ -47,7 +47,7 @@ namespace DCGO.CardEffects.ST19
                 
                 bool CanActivateCondition(Hashtable hashtable)
                 {
-                    return CardEffectCommons.IsExistOnBattleAreaDigimon(card) &&
+                    return CardEffectCommons.CanActivateOnDeletion(card) &&
                            CardEffectCommons.HasMatchConditionOwnersHand(card, HasPuppetInTrait);
                 }
 

Assets/CardEffect/ST19/Yellow/Chaperomon_ST19_11.cs

@@ -28,7 +28,7 @@ namespace DCGO.CardEffects.ST19
 
             bool CanActivateSharedCondition(Hashtable hashtable)
             {
-                return CardEffectCommons.CanActivateOnDeletion(card) &&
+                return CardEffectCommons.IsExistOnBattleAreaDigimon(card) &&
                        CardEffectCommons.HasMatchConditionPermanent(CanSelectPermanentSharedCondition);
             }
 
@@ -45,7 +45,7 @@ namespace DCGO.CardEffects.ST19
 
                 string EffectDescription()
                 {
-                    return "[On Play] 1 of your opponent's Digimon gets -3000 DP for the turn.";
+                    return "[On Play] 1 of your opponent's Digimon gets -3000 DP for the turn. If there are 3 or more Digimon, increase the DP reduction of this effect by -3000.";
                 }
 
                 bool CanUseCondition(Hashtable hashtable)
@@ -96,7 +96,7 @@ namespace DCGO.CardEffects.ST19
 
                 string EffectDescription()
                 {
-                    return "[When Digivolving] 1 of your opponent's Digimon gets -3000 DP for the turn.";
+                    return "[When Digivolving] 1 of your opponent's Digimon gets -3000 DP for the turn. If there are 3 or more Digimon, increase the DP reduction of this effect by -3000.";
                 }
 
                 bool CanUseCondition(Hashtable hashtable)

Assets/CardEffect/ST19/Yellow/Doggymon_ST19_06.cs

@@ -16,12 +16,6 @@ namespace DCGO.CardEffects.ST19
                 return CardEffectCommons.IsPermanentExistsOnOpponentBattleAreaDigimon(permanent, card);
             }
 
-            bool CanActivateCondition(Hashtable hashtable)
-            {
-                return CardEffectCommons.IsExistOnBattleAreaDigimon(card) &&
-                       CardEffectCommons.HasMatchConditionPermanent(CanSelectPermanentCondition);
-            }
-
             #endregion
 
             #region On Play
@@ -36,7 +30,7 @@ namespace DCGO.CardEffects.ST19
                 string EffectDescription()
                 {
                     return
-                        "[When Digivolving] 1 of your opponent's Digimon gains <Security Attack -1> until the end of their turn.";
+                        "[On Play] 1 of your opponent's Digimon gains <Security Attack -1> until the end of their turn.";
                 }
 
                 bool CanUseCondition(Hashtable hashtable)
@@ -44,6 +38,12 @@ namespace DCGO.CardEffects.ST19
                     return CardEffectCommons.CanTriggerOnPlay(hashtable, card);
                 }
 
+                bool CanActivateCondition(Hashtable hashtable)
+                {
+                    return CardEffectCommons.IsExistOnBattleAreaDigimon(card) &&
+                           CardEffectCommons.HasMatchConditionPermanent(CanSelectPermanentCondition);
+                }
+
                 IEnumerator ActivateCoroutine(Hashtable hashtable)
                 {
                     SelectPermanentEffect selectPermanentEffect = GManager.instance.GetComponent<SelectPermanentEffect>();
@@ -92,7 +92,7 @@ namespace DCGO.CardEffects.ST19
                 string EffectDescription()
                 {
                     return
-                        "[When Digivolving] 1 of your opponent's Digimon gains <Security Attack -1> until the end of their turn.";
+                        "[On Deletion] 1 of your opponent's Digimon gains <Security Attack -1> until the end of their turn.";
                 }
 
                 bool CanUseCondition(Hashtable hashtable)
@@ -100,6 +100,12 @@ namespace DCGO.CardEffects.ST19
                     return CardEffectCommons.CanTriggerOnDeletion(hashtable, card);
                 }
 
+                bool CanActivateCondition(Hashtable hashtable)
+                {
+                    return CardEffectCommons.CanActivateOnDeletion(card) &&
+                           CardEffectCommons.HasMatchConditionPermanent(CanSelectPermanentCondition);
+                }
+
                 IEnumerator ActivateCoroutine(Hashtable hashtable)
                 {
                     SelectPermanentEffect selectPermanentEffect = GManager.instance.GetComponent<SelectPermanentEffect>();

Assets/CardEffect/ST19/Yellow/Kyaromon_ST19_01.cs

@@ -17,6 +17,7 @@ namespace DCGO.CardEffects.ST19
                 activateClass.SetUpICardEffect("Draw 1", CanUseCondition, card);
                 activateClass.SetUpActivateClass(CanActivateCondition, ActivateCoroutine, 1, false, EffectDescription());
                 activateClass.SetIsInheritedEffect(true);
+                activateClass.SetHashString("Draw_ST19_01");
                 cardEffects.Add(activateClass);
 
                 string EffectDescription()

Assets/CardEffect/ST19/Yellow/Pandamon_ST19_09.cs

@@ -52,7 +52,7 @@ namespace DCGO.CardEffects.ST19
 
                 bool CanActivateCondition(Hashtable hashtable)
                 {
-                    return CardEffectCommons.IsExistOnBattleAreaDigimon(card) &&
+                    return CardEffectCommons.CanActivateOnDeletion(card) &&
                            CardEffectCommons.HasMatchConditionOwnersHand(card, IsLevel3PuppetCardCondition);
                 }